Merged
Conversation
The `BackticksRunner` and `PopenRunner` do not support outputs on `stderr`, therefore the spec that verifies whether large output on `stderr` hangs or not, doesn't make sense for these runners. The only reason it works on MRI is because the way the spec is written, selects the `ProcessRunner`. On JRuby the `ProcessRunner` is not supported, so it falls back to the `BackticksRunner` and then makes the spec fail.
nickcharlton
force-pushed
the
fix-stderr-test
branch
from
e448ab1 to
5df28a4
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BackticksRunnerandPopenRunnerdo not support outputs onstderr, therefore the spec that verifies whether large output onstderrhangs or not, doesn't make sense for these runners.The only reason it works on MRI is because the way the spec is written, selects the
ProcessRunner.On JRuby the
ProcessRunneris not supported, so it falls back to theBackticksRunnerand then makes the spec fail.